[PATCH] D20951: [RFC][ARM][LLD] Initial support for ARM in lld

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 6 09:56:02 PDT 2016


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM with a few nits.


================
Comment at: ELF/Target.cpp:1462-1465
@@ +1461,6 @@
+    return R_ABS;
+  case R_ARM_PC24:
+  case R_ARM_PLT32:
+  case R_ARM_CALL:
+  case R_ARM_JUMP24:
+    return R_PLT_PC;
----------------
Sort

================
Comment at: ELF/Target.cpp:1585-1586
@@ +1584,4 @@
+    break;
+  case R_ARM_REL32:
+    return SignExtend64<32>(read32le(Buf));
+  case R_ARM_CALL:
----------------
You can merge this with R_ARM_ABS32 case.


http://reviews.llvm.org/D20951





More information about the llvm-commits mailing list