[PATCH] D19338: New code hoisting pass based on GVN (optimistic approach)

[Daniel Berlin via llvm-commits]

dberlin added inline comments.

================
Comment at: llvm/lib/Transforms/Scalar/GVNHoist.cpp:125
@@ +124,3 @@
+    VNS += std::to_string(VN.lookupOrAdd(Val));
+    VNtoStores.insert(std::make_pair(std::hash<std::string>()(VNS), Store));
+  }
----------------
dberlin wrote:
> Please use std::pair, or define an appropriate key, not convert vn numbers to strings :)
> 
(IE use hash_combine and make that work, or whatever)


http://reviews.llvm.org/D19338