[PATCH] D20962: [Polly][GSoC 2016]New function pass ScopInfoWrapperPass

[Michael Kruse via llvm-commits]

Meinersbur added inline comments.

================
Comment at: include/polly/ScopInfo.h:2556-2557
@@ +2555,4 @@
+
+  iterator begin() { return regionToScopMap.begin(); }
+  iterator end() { return regionToScopMap.end(); }
+
----------------
You declared a `const_iterator` type. Can you also define const `begin()` and `end()`?

================
Comment at: lib/Analysis/ScopInfo.cpp:4876
@@ -4875,1 +4875,3 @@
+/// Implementation of ScopInfoRegionPass begins here.
+//
 void ScopInfoRegionPass::getAnalysisUsage(AnalysisUsage &AU) const {
----------------
jdoerfert wrote:
> I don't like such lines, if nobody is in favour of them I would say we do not introduce them.
I second that.

================
Comment at: lib/Analysis/ScopInfo.cpp:4951
@@ +4950,3 @@
+  auto &SD = getAnalysis<ScopDetection>();
+  Region *R;
+
----------------
Can you use inline declarations when possible?
    auto *R = const_cast<Region *>(*I);


http://reviews.llvm.org/D20962