[PATCH] D20998: [InstCombine][SSE] Add MOVMSK constant folding (PR27982)
Ahmed Bougacha via llvm-commits
llvm-commits at lists.llvm.org
Sun Jun 5 19:48:05 PDT 2016
ab accepted this revision.
ab added a comment.
This revision is now accepted and ready to land.
LGTM, with one nit.
================
Comment at: lib/Transforms/InstCombine/InstCombineCalls.cpp:348
@@ +347,3 @@
+ APInt Result(ResTy->getPrimitiveSizeInBits(), 0);
+ for (unsigned i = 0, E = ArgTy->getVectorNumElements(); i != E; ++i) {
+ auto *COp = C->getAggregateElement(i);
----------------
i -> I ?
Or, since I is confusing: EI/EE? AI/AE?
Repository:
rL LLVM
http://reviews.llvm.org/D20998
More information about the llvm-commits
mailing list