[PATCH] D20769: [IPRA] Interprocedural Register Allocation - Analysis Passes

[Vivek Pandya via llvm-commits]

vivekvpandya added inline comments.

================
Comment at: test/CodeGen/Generic/reg-usage-info.ll:2
@@ +1,3 @@
+; RUN: llc -enable-ipra -debug-only=ip-regalloc -o /dev/null 2>&1 < %s  | FileCheck %s
+; REQUIRES: asserts
+; CHECK: Function Name : fib
----------------
mehdi_amini wrote:
> vivekvpandya wrote:
> > mehdi_amini wrote:
> > > I don't like that we can't pass the test in release mode. I suggested that the dump occurs in `doFinalization()` for the analysis pass (i.e. `PhysicalRegisterUsageInfo`).  You need to implement a proper cl::opt that controls a dump there, that could be used in release mode.
> > Aren't we refering 
> > ```RegUsageInfoCollector```  
> > as analysis pass, 
> > ```RegisterUsageInfo``` 
> > is there for keeping data around.
> Technically in LLVM the analysis is the pass that you require and query the result from (i.e. a pass you're using as `getAnalysis()`). But yeah terminology can be fuzzy.
SO What is your suggestion? Which file should be changed?


http://reviews.llvm.org/D20769