[PATCH] D20769: [IPRA] Interprocedural Register Allocation - Analysis Passes

[Vivek Pandya via llvm-commits]

vivekvpandya added inline comments.

================
Comment at: test/CodeGen/Generic/reg-usage-info.ll:2
@@ +1,3 @@
+; RUN: llc -enable-ipra -debug-only=ip-regalloc -o /dev/null 2>&1 < %s  | FileCheck %s
+; REQUIRES: asserts
+; CHECK: Function Name : fib
----------------
mehdi_amini wrote:
> I don't like that we can't pass the test in release mode. I suggested that the dump occurs in `doFinalization()` for the analysis pass (i.e. `PhysicalRegisterUsageInfo`).  You need to implement a proper cl::opt that controls a dump there, that could be used in release mode.
Aren't we refering 
```RegUsageInfoCollector```  
as analysis pass, 
```RegisterUsageInfo``` 
is there for keeping data around.

================
Comment at: test/CodeGen/Generic/reg-usage-info.ll:4
@@ +3,3 @@
+; CHECK: Function Name : fib
+; CHECK: Clobbered Registers: 1 3 19 35 2 3 19 35 4 8 21 37 5 8 21 37 15 14 23 39 25 1 3 19 35 2 3 19 35 7 6 20 36 4 8 21 37 5 8 21 37 48 47 30 44
+
----------------
mehdi_amini wrote:
> I'm worried that we don't provide any stability guarantee on the numbers printed here.
> Having a nicer textual form would be better. 
> I just don't see how to do it other than keep a pointer to the TRI in the DenseMap in the immutable pass to be able to get the register name.
If RegUsageInfoCollector is considered as analysis pass then we can add cl::opt into that file and have analysis printed from that.


http://reviews.llvm.org/D20769