[PATCH] D20925: FileCheck: print input on errors

[Xinliang David Li via llvm-commits]

On Sun, Jun 5, 2016 at 10:06 AM, Dmitry Vyukov <dvyukov at google.com> wrote:

> On Sun, Jun 5, 2016 at 7:02 PM, Xinliang David Li <xinliangli at gmail.com>
> wrote:
> > 1) the output is less verbose
> > 2) The actionable stuff is captured in one script.
> >
> > isn't it what you want?
>
>
> The output must be useful and actionable in the first place. If we
> would care only about verbosity then we would print nothing. Empty
> output is the shortest.
>

This is not the right argument by going to the extreme. The goal should be
using the minimal output to capture the max possible context, so verbosity
is just one side of the equation.


>
> With what you propose it is not possible to see output on buildbots.
>
>
You are right about buildbot use case -- which I missed.  I agree in that
mode perhaps the more verbose the better :)

David




>
>
>
> > On Sun, Jun 5, 2016 at 9:46 AM, Dmitry Vyukov <dvyukov at google.com>
> wrote:
> >>
> >> Why is it better? When you don't want to see the input?
> >>
> >> On Sun, Jun 5, 2016 at 6:25 PM, Xinliang David Li <xinliangli at gmail.com
> >
> >> wrote:
> >> > I think the better approach is to capture the input and re-run command
> >> > line
> >> > in a temporary file by default.
> >> > 1) create a re-run file: rerun_script
> >> > 2) dump the following to rerun_script:
> >> > cat << EOF > input_tmp
> >> >   ..... input here
> >> > EOF
> >> >
> >> > cat input_tmp | <FileCheck Command>
> >> >
> >> > 3) in error message, show " To rerun, run rerun_script ".
> >> >
> >> >  David
> >> >
> >> >
> >> > On Sun, Jun 5, 2016 at 8:49 AM, Dmitry Vyukov via llvm-commits
> >> > <llvm-commits at lists.llvm.org> wrote:
> >> >>
> >> >> dvyukov added a comment.
> >> >>
> >> >> > FYI, see also http://reviews.llvm.org/D20105
> >> >>
> >> >>
> >> >> Answered there. I don't understand why printing input is not the
> >> >> default.
> >> >>
> >> >>
> >> >> http://reviews.llvm.org/D20925
> >> >>
> >> >>
> >> >>
> >> >> _______________________________________________
> >> >> llvm-commits mailing list
> >> >> llvm-commits at lists.llvm.org
> >> >> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
> >> >
> >> >
> >
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160605/0603052d/attachment.html>