[lld] r263070 - [lto] Add saving the LTO .o file to -save-temps.

[Chandler Carruth via llvm-commits]

Sorry to dredge up an old commit, but I just saw this test spuriously fail:

http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/14073

My commit seems unlikely to have triggered this, and the next build "fixed"
the test. I'm worried there is something non-deterministic going on here.
When reading this patch I noticed one thing below:

On Wed, Mar 9, 2016 at 2:34 PM Sean Silva via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

>
> ==============================================================================
> --- lld/trunk/test/ELF/lto/save-temps.ll (original)
> +++ lld/trunk/test/ELF/lto/save-temps.ll Wed Mar  9 16:30:05 2016
> @@ -1,10 +1,11 @@
>  ; REQUIRES: x86
> -; RUN: rm -f %t.so %t.so.lto.bc
> +; RUN: rm -f %t.so %t.so.lto.bc %t.so.lto.o
>  ; RUN: llvm-as %s -o %t.o
>  ; RUN: llvm-as %p/Inputs/save-temps.ll -o %t2.o
>  ; RUN: ld.lld -shared -m elf_x86_64 %t.o %t2.o -o %t.so -save-temps
>  ; RUN: llvm-nm %t.so | FileCheck %s
>  ; RUN: llvm-nm %t.so.lto.bc | FileCheck %s
> +; RUN: llvm-nm %t.so.lto.o | FileCheck %s
>
>  target triple = "x86_64-unknown-linux-gnu"
>  target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
> @@ -13,5 +14,5 @@ define void @foo() {
>    ret void
>  }
>
> -; CHECK-DAG: T bar
> -; CHECK-DAG: T foo
> +; CHECK: T bar
> +; CHECK: T foo
>

This change seems odd and unrelated to me.

If the CHECK-DAG was required, that shows some lack of deterministic output
here. This change seems unlikely to have fixed any such non-determinism.

Sadly, this seems unlikely to explain the spurious failure I just saw. =/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160604/e401875d/attachment.html>