[PATCH] D20884: This patch attempts to primitive support for Win64 asan

Wang Wei via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 4 11:25:04 PDT 2016


wang0109 added inline comments.

================
Comment at: lib/interception/interception_win.cc:46
@@ -45,1 +45,3 @@
 
+static void WriteIndirectJumpInstruction(char *jmp_from, uptr *indirect_target) {  // NOLINT
+  // jmp [rip + XXYYZZWW] = FF 25 WW ZZ YY XX, where
----------------
rnk wrote:
> Why NOLINT?
If I remember correctly, it's over 80-characters in width. I'll double check.


http://reviews.llvm.org/D20884





More information about the llvm-commits mailing list