[PATCH] D20943: [LibFuzzer] [WIP] Declare and use sanitizer functions in ``fuzzer::ExternalFunctions``
Kostya Serebryany via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 3 19:17:13 PDT 2016
kcc added inline comments.
================
Comment at: lib/Fuzzer/FuzzerIO.cpp:126
@@ -128,3 +125,3 @@
OutputFile = NewOutputFile;
- if (__sanitizer_set_report_fd)
- __sanitizer_set_report_fd(reinterpret_cast<void*>(OutputFd));
+ fuzzer::ExternalFunctions EF;
+ if (EF.__sanitizer_set_report_fd)
----------------
delcypher wrote:
> kcc wrote:
> > Ouch. That's becoming too annoying.
> > Let's just have a singleton global object "fuzzer::ExternalFunctions *EF" that we initialized at startup
> > and delete all private instances.
> >
> Do you want this change to be in this patch or a subsequent patch?
I don't want you to introduce one more EF here, so yes, in this patch.
http://reviews.llvm.org/D20943
More information about the llvm-commits
mailing list