[PATCH] D20988: [cpu-detection] Substantial refactor of Host CPU detection code (x86)

[Eric Christopher via llvm-commits]

echristo added a comment.

Yes, we really do want this in compiler-rt. We support the builtins via clang and there's no reason not to have the runtime support.

I understand you have some reservations about using strings rather than enums in the intrinsics, but that seems like a bit of a bikeshed to the general support for querying (and caching in the compiler-rt side) cpu id features. If we need to design a new interface we can do that separately and do what we need there while still supporting the old interfaces.

Also, ultimately, this side of things is still just a nice cleanup for the existing code in Host.cpp and so I think it's a worthwhile patch for now.

Thanks.

-eric


http://reviews.llvm.org/D20988