[PATCH] D20924: [codeview] Add basic record type translation

[Amjad Aboud via llvm-commits]

aaboud added inline comments.

================
Comment at: llvm/trunk/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:1173
@@ -981,1 +1172,3 @@
+
+  InsertResult.first->second = TI;
   return TI;
----------------
I am not very much familiar with DenseMap, but I guess that the iterator we are holding in InsertResult.first might not remain valid in case we insert a new entry to CompleTypeIndices, which could happen while creating the complete class. For example, when we have nested classes.



Repository:
  rL LLVM

http://reviews.llvm.org/D20924