[PATCH] D20975: [libfuzzer] hiding custom mutator handling in MutationDispatcher.

Kostya Serebryany via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 3 13:47:31 PDT 2016


kcc added inline comments.

================
Comment at: lib/Fuzzer/FuzzerInternal.h:474
@@ -473,3 +483,1 @@
-  // Interface to functions that may or may not be available.
-  ExternalFunctions EF;
 };
----------------
This works now, but Dan was going to extend this with more weak functions (__sanitizer_*) and EF will be needed in other places of libFuzzer. 
Please leave it here. 

================
Comment at: lib/Fuzzer/FuzzerMutate.cpp:43
@@ +42,3 @@
+  } else {
+    Mutators.insert(Mutators.begin(), DefaultMutators.begin(),
+                    DefaultMutators.end());
----------------
Why not Mutators = DefaultMUtators? 
also remove {}

================
Comment at: lib/Fuzzer/FuzzerMutate.cpp:253
@@ +252,3 @@
+
+size_t MutationDispatcher::DefaultMutate(uint8_t *Data, size_t Size,
+                                         size_t MaxSize) {
----------------
Probably also change LLVMFuzzerMutate to call this one. 


http://reviews.llvm.org/D20975





More information about the llvm-commits mailing list