[PATCH] D20945: pdbdump: print out TPI hashes

[Zachary Turner via llvm-commits]

zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.

Looks good after rebasing and moving the print method


================
Comment at: include/llvm/DebugInfo/CodeView/StreamArray.h:248
@@ -252,5 +247,3 @@
   FixedStreamArrayIterator<T> &operator++() {
-    if (Index == uint32_t(-1))
-      return *this;
-    if (++Index >= Array.size())
-      Index = uint32_t(-1);
+    assert(Index != Array.size());
+    ++Index;
----------------
Perhaps assert that `Index < Array.size()` instead.

================
Comment at: tools/llvm-pdbdump/llvm-pdbdump.cpp:698
@@ +697,3 @@
+
+static void dumpTpiHash(ScopedPrinter &P, TpiStream &Tpi) {
+  if (!opts::DumpTpiHash)
----------------
I think you will need to rebase and move this method to a pure virtual method on `OutputStyle` and implement it in `LLVMOutputStyle`.  Sorry :-/  Good news is I should be done with all the intrusive changes now and can work in isolation entirely on the yaml outputter.


http://reviews.llvm.org/D20945