[PATCH] D20981: AMDGPU: Remove incorrect assertion

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 3 12:36:06 PDT 2016


arsenm created this revision.
arsenm added a reviewer: tstellarAMD.
arsenm added a subscriber: llvm-commits.
Herald added subscribers: kzhuravl, arsenm.

I'm still not sure under what circumstances the offset here is non-0,
but private memory is not limited to 27-bits.

http://reviews.llvm.org/D20981

Files:
  lib/Target/AMDGPU/SIRegisterInfo.cpp

Index: lib/Target/AMDGPU/SIRegisterInfo.cpp
===================================================================
--- lib/Target/AMDGPU/SIRegisterInfo.cpp
+++ lib/Target/AMDGPU/SIRegisterInfo.cpp
@@ -277,10 +277,6 @@
   const AMDGPUSubtarget &Subtarget = MF->getSubtarget<AMDGPUSubtarget>();
   const TargetInstrInfo *TII = Subtarget.getInstrInfo();
 
-  assert(isUInt<27>(Offset) &&
-         "Private offset should never exceed maximum private size");
-
-
   if (Offset == 0) {
     BuildMI(*MBB, Ins, DL, TII->get(AMDGPU::V_MOV_B32_e32), BaseReg)
       .addFrameIndex(FrameIdx);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D20981.59601.patch
Type: text/x-patch
Size: 581 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160603/cfc61546/attachment.bin>


More information about the llvm-commits mailing list