[PATCH] D20947: [LibFuzzer] Disable building and running LSan tests on Apple platforms because LSan is not currently supported.

[Kostya Serebryany via llvm-commits]

kcc added a comment.

In http://reviews.llvm.org/D20947#448547, @delcypher wrote:

> In http://reviews.llvm.org/D20947#448542, @delcypher wrote:
>
> > @kcc:
> >
> > > Why do you need to disable building the tests? 
> >
> > >  I would expect that "REQUIRES: lsan" is enough. No?
> >
> >
> > My original version (not uploaded to phabricator) of the patch actually didn't disable building the tests. I decided to disable building them because I thought it was to build tests that would never be executed. However if you prefer I can change the patch to always build the tests because they do build successfully.
>
>
> Sorry
>
> s/because I thought it was to build/because I thought it was odd to build/


Building these tests is very cheap. 
Not building them makes the cmake file more complex. 
If we can trade a tiny bit of CPU for less complexity we should do it.


================
Comment at: lib/Fuzzer/test/CMakeLists.txt:97
@@ +96,3 @@
+  message(WARNING "Leak sanitizer is not supported on Apple platforms."
+    " Building and running LibFuzzer leak sanitizer tests is disabled."
+    )
----------------
delcypher wrote:
> kcc wrote:
> > LeakSanitizer
> The error message for the "DataflowSanitizer" tests is similarly worded. Do you want that fixed too?
Yes, would be great. 


http://reviews.llvm.org/D20947