[PATCH] D20956: [ELF] - Assign sh_link field of SHT_GNU_versym section to DynSymTab section index
Rui Ueyama via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 3 11:06:19 PDT 2016
ruiu accepted this revision.
ruiu added a comment.
LGTM with a nit.
================
Comment at: ELF/OutputSections.cpp:1421
@@ -1420,2 +1420,3 @@
this->Header.sh_entsize = sizeof(Elf_Versym);
+ this->Header.sh_link = Out<ELFT>::DynSymTab->SectionIndex;
}
----------------
Please add a comment saying that setting sh_link is not required by any spec but we do since readelf assumes it.
http://reviews.llvm.org/D20956
More information about the llvm-commits
mailing list