[PATCH] D16829: An implementation of Swing Modulo Scheduling

[Stephen Hines via llvm-commits]

srhines added a comment.

In http://reviews.llvm.org/D16829#448414, @qcolombet wrote:

> Hi Stephen,
>
> I will have a look if no-one did at some point.
>  I am way behind in reviews and open source work in general and I do not expect to be able to look at it before at least a couple of weeks.
>
> Therefore, be patient, keep pinging people, and eventually the review will happen :).


No problem. I just want to make sure that this has a reasonable chance of being submitted in a reasonable timeframe.

> Thanks for working on this BTW!


I actually am just trying to help shepherd this along, as we have users who really want this feature enabled for Hexagon. I didn't do any of the work here. All of the credit goes to the original author(s).

> Cheers,

> -Quentin

> 

> PS: I tend to look at reviews that do not have active reviewers. For that thread, a bunch of people commented on it and thus I thought it was already well covered. Sorry for not having looked earlier.


Ah, there were indeed some great reviews earlier, but I think that the concern was one of adding a new pass to LLVM without more extensive approval (i.e. a more senior contributor actually saying "Accept"). If you think that the other reviewers have done a sufficient job here (or that no additional reviews are needed, and anything else can be fixed up post-commit), please say so. Thanks again for taking time to respond and for the quick glance.


http://reviews.llvm.org/D16829