[PATCH] D20955: [Sparc] Complex return value ABI compliance.

[James Y Knight via llvm-commits]

jyknight added a comment.

I would prefer if the change was structured as WebAssemblyABIInfo is: override computeInfo (with the same source code as the base, calling classify*), and then make a new classifyReturnType. That will make it easier for future fixes (e.g. properly supporting "long double", which we don't right now).

Also: we do implement integer complex numbers as well as floats. The ABI doc you linked doesn't seem to address those, but GCC passes them back in multiple integer registers (e.g. "long long __complex__" writes values into o0 through o3). Your change looks to already do that, as well, but that seems worth a comment and a test.


Repository:
  rL LLVM

http://reviews.llvm.org/D20955