[PATCH] D20774: [InstCombine] look through bitcasts to find selects

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 3 07:10:03 PDT 2016


On Thu, Jun 2, 2016 at 5:15 PM, David Majnemer <david.majnemer at gmail.com>
wrote:

>
> It would be nice if we could find a way to fold the code which handles the
> bitcast case with the code which doesn't.
>
>
Looks like Phab ate another inline comment without sending it to the list.
I posted this yesterday:

"Agreed - at the least, we can use m_CombineOr in the same way to make the
code look similar.
However, after my bot-killing / bug-raising misadventure in rL269728
<http://reviews.llvm.org/rL269728>, I'm determined to make any refactoring
a follow-up step. :)
I'll add a FIXME comment in this patch. Thank you for the prompt review!"




>
> http://reviews.llvm.org/D20774
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160603/9282b838/attachment.html>


More information about the llvm-commits mailing list