[PATCH] D20912: [Polly][GSoC 2016]Update ScopBuilder's memory management

Michael Kruse via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 3 05:17:04 PDT 2016


Meinersbur added inline comments.

================
Comment at: include/polly/ScopInfo.h:2488
@@ -2491,1 +2487,3 @@
+  /// @brief The Scop pointer which is used to construct a Scop.
+  std::unique_ptr<Scop> scop;
 
----------------
sebpop wrote:
> Variable names should start with capital letters: "Scop".
'Scop' is already the name of the class; using it for variable names leads to disambiguation problems in the C++ parser.

I suggest to use just 'S' or invent something else. e.g. 'Part' (What the P stands for in Scop).


http://reviews.llvm.org/D20912





More information about the llvm-commits mailing list