[PATCH] D19271: Change CALL_ONCE_INITIALIZATION implementation to use static initialization

[Mehdi AMINI via llvm-commits]

mehdi_amini added a comment.

In http://reviews.llvm.org/D19271#447313, @krytarowski wrote:

> In http://reviews.llvm.org/D19271#447193, @mehdi_amini wrote:
>
> > Kamil: what's up on the NetBSD side by the way? If there is no plan to fix the combination of NetBSD + stdlibc++, we'll have to drop support for it at some point.
>
>
> It's a bug that affects only libstdc++ in dynamic linking, static works. Also `std::call_once` libc++ works.
>
> Dropping a platform for little reason isn't reasonable. Maybe we can prepare a CMake test detecting if it works, if so than enable it. After that libstc++ on NetBSD won't be holding back others.


"Little reason" is very subjective, so I'll be fine disagreeing with you: if this is an important configuration to support (dynamic link + NetBSD + libstdc++), then I expect someone that maintain this platform to make sure that there is a path forward (i.e. the problem is reported upstream to gcc developer, etc.). If a platform does not support correctly the C++ standard, dropping support for this platform is something that is reasonable to me, and I believe this is how we evaluated every platform/configuration drop in the past (we dropped MSVC2012 for this reason).

(I use platform as the combination of the OS+stdlib+host compiler+...)


http://reviews.llvm.org/D19271