[PATCH] D20891: [WebAssembly] Emit type signatures for declared functions

Dan Gohman via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 2 14:24:53 PDT 2016


sunfish accepted this revision.
sunfish added a comment.
This revision is now accepted and ready to land.

Ok, as we discussed on IRC, we may do other things in the future, but for now this looks good.


================
Comment at: lib/Target/WebAssembly/MCTargetDesc/WebAssemblyTargetStreamer.h:43
@@ -40,1 +42,3 @@
+                                        SmallVectorImpl<MVT> &SignatureVTs,
+                                        size_t NumResults) {}
 };
----------------
This should probably contain an abort so that we don't have a silent difference between a .s file and a .o file.


http://reviews.llvm.org/D20891





More information about the llvm-commits mailing list