[PATCH] D20549: [lit] Use os.devnull instead of named temp files

Yunzhong Gao via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 2 11:51:49 PDT 2016


ygao added a comment.

Hi, sorry for the delay.
I tested your change on a 64-bit Windows 7 machine and it works fine. It seems a good idea to use os.devnull instead of a temporary file. Thanks.
I am not very familiar with the code myself to give a LGTM, so a second review would be appreciated.


http://reviews.llvm.org/D20549





More information about the llvm-commits mailing list