[PATCH] D20900: [CodeView] Implement function-type indices

[Amjad Aboud via llvm-commits]

aaboud added a comment.

LGTM.
Only one comment (you might want to fix it in a follow up commit).


================
Comment at: llvm/trunk/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:129
@@ -132,1 +128,3 @@
+  if (!SP)
+    return TypeIndex::Void();
 
----------------
Should not we return TypeIndex(0) in this case?
Or even better TypeIndex::None(), where:
static TypeIndex None() { return TypeIndex(SimpleTypeKind::None); }


Repository:
  rL LLVM

http://reviews.llvm.org/D20900