[PATCH] D19391: transform obscured FP sign bit ops into a fabs/fneg using TLI hook

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 2 10:52:08 PDT 2016


spatel added a comment.

In http://reviews.llvm.org/D19391#447172, @majnemer wrote:

> I'm not sure if what we were allowed to assume about the bitpattern of float/double from the middle end.
>  If it's fine, then this LGTM without touching ValueTracking.


Ah, right - the LangRef doesn't specify anything about the FP formats. Let's be safe then. I'll update this patch to revert http://reviews.llvm.org/rL249701 .


http://reviews.llvm.org/D19391





More information about the llvm-commits mailing list