[PATCH] D20661: [esan|cfrag] Create the cfrag struct array for the runtime

Vitaly Buka via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 2 10:29:41 PDT 2016


vitalybuka added inline comments.

================
Comment at: lib/Transforms/Instrumentation/EfficiencySanitizer.cpp:95
@@ -88,3 +94,3 @@
 namespace {
 
 static EfficiencySanitizerOptions
----------------
Maybe try to put everything above into namespace {} and remove static?

================
Comment at: lib/Transforms/Instrumentation/EfficiencySanitizer.cpp:319
@@ +318,3 @@
+    GlobalVariable *Counters =
+      new GlobalVariable(M, CounterArrayTy, false,
+                         GlobalVariable::WeakAnyLinkage,
----------------
git clang-format -f origin --style=file


http://reviews.llvm.org/D20661





More information about the llvm-commits mailing list