[PATCH] D19391: transform obscured FP sign bit ops into a fabs/fneg using TLI hook

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 2 10:20:44 PDT 2016


spatel added a comment.

In http://reviews.llvm.org/D19391#447144, @majnemer wrote:

> IIRC, I asked you to add support for `fabs` to `computeKnownBits` when you added this canonicalization.


Yes, that was http://reviews.llvm.org/D13222 / http://reviews.llvm.org/rL249701 .

> Seeing as how the canonicalization is removed, I think we should undo this aspect of `computeKnownBits`.


What is the advantage of removing the analysis? It is still true that an llvm fabs() intrinsic clears the sign bit in all cases, right?


http://reviews.llvm.org/D19391





More information about the llvm-commits mailing list