[PATCH] D17257: New utility class ReachingPhysDefs for post-ra analysis.

[Jonas Paulsson via llvm-commits]

jonpa updated this revision to Diff 59410.
jonpa marked 19 inline comments as done.
jonpa added a comment.

Patch updated according to review.

Quentin: Regarding commenting - I think you would be best suited for the ADRP class. Otherwise comments have been updated hopefully as requested.

I removed the const on MachineInstrs in SetOfMachineInstr and InstrToInstrs. This was done when using this class in SystemZElimCompare where the users of CC are updated (non-const operations). I then thought it would be necessary to give users of the algorithm this freedom, and removed the const. Is there a better option?

I have reused the reverse post-order algo as suggested, but not tested it. First I wonder if there is any progress on deciding if ReachingPhysDefs or the RDF should go in?


http://reviews.llvm.org/D17257

Files:
  include/llvm/CodeGen/ReachingPhysDefs.h
  lib/CodeGen/CMakeLists.txt
  lib/CodeGen/ReachingPhysDefs.cpp
  lib/Target/AArch64/AArch64CollectLOH.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D17257.59410.patch
Type: text/x-patch
Size: 58404 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160602/5c807756/attachment.bin>