[PATCH] D20900: [CodeView] Implement function-type indices

[Reid Kleckner via llvm-commits]

rnk added a comment.

Test? You can probably update types-basic.ll, since it has functions in it already.


================
Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:929
@@ +928,3 @@
+TypeIndex CodeViewDebug::lowerTypeFunction(const DISubroutineType *Ty) {
+  SmallVector<TypeIndex, 8> ReturnAndArgTypeIndices;
+  for (DITypeRef ArgTypeRef : Ty->getTypeArray())
----------------
FIXME to deal with instance methods

================
Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:944
@@ +943,3 @@
+
+  ProcedureRecord Procedure(ReturnTypeIndex, CallingConvention::NearC,
+                            FunctionOptions::None, 0, ArgListIndex);
----------------
FIXME about pushing DW_AT_calling_convention through the metadata


http://reviews.llvm.org/D20900