[PATCH] D20741: [LibFuzzer] Reimplement how the optional user functions are called.

Kostya Serebryany via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 1 21:15:40 PDT 2016


kcc accepted this revision.
kcc added a comment.
This revision is now accepted and ready to land.

LGTM with 3 nits. 
Ok to commit once you fix them (assuming all tests still work on Linux)
Thanks!


================
Comment at: lib/Fuzzer/FuzzerExtFunctionsDlsym.cpp:1
@@ +1,2 @@
+//===- FuzzerExtFunctions.cpp - Interface to external functions --*- C++ -* ==//
+//
----------------
Fix the file name in the comment

================
Comment at: lib/Fuzzer/FuzzerExtFunctionsWeak.cpp:1
@@ +1,2 @@
+//===- FuzzerExtFunctions.cpp - Interface to external functions --*- C++ -* ==//
+//
----------------
fix file name

================
Comment at: lib/Fuzzer/FuzzerLoop.cpp:150
@@ -152,3 +149,3 @@
 Fuzzer::Fuzzer(UserCallback CB, MutationDispatcher &MD, FuzzingOptions Options)
-    : CB(CB), MD(MD), Options(Options) {
+    : CB(CB), MD(MD), Options(Options), EF(ExternalFunctions()) {
   SetDeathCallback();
----------------
Why do you need this now? 


http://reviews.llvm.org/D20741





More information about the llvm-commits mailing list