[PATCH] D18960: [lld] Initial implementation of TLSDESC relocation handling

[Rafael Espíndola via llvm-commits]

BTW, I setting up an aarch64 dev env. This is the first patch to review, right?

Cheers,
Rafael


On 1 June 2016 at 15:37, Rafael Espíndola <rafael.espindola at gmail.com> wrote:
> On 10 May 2016 at 07:57, Ed Maste <emaste at freebsd.org> wrote:
>> emaste added inline comments.
>>
>> ================
>> Comment at: ELF/OutputSections.h:297
>> @@ -287,2 +296,3 @@
>>    std::vector<DynamicReloc<ELFT>> Relocs;
>> +  std::vector<DynamicReloc<ELFT>> TlsDescRelocs;
>>  };
>> ----------------
>> rafael wrote:
>>> Why do you need the second vector? It seems you just relocate it at the same time as Relocs.
>> The TLSDESC relocs have to follow the others; earlier versions of the patch kept track of the number of different types and inserted at the appropriate point in the vector (and a middle version had a vector of reloc vectors), but this way seems more clear to me.
>
> Where is that documented?
>
> Cheers,
> Rafael