[PATCH] D20876: [PDB] Print section contributions and section map

[Reid Kleckner via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm with nits


================
Comment at: include/llvm/DebugInfo/PDB/Raw/DbiStream.h:74
@@ -66,3 +73,3 @@
   codeview::StreamRef ModInfoSubstream;
   codeview::StreamRef SecContrSubstream;
   codeview::StreamRef SecMapSubstream;
----------------
s/Contr/Contrib/?

================
Comment at: lib/DebugInfo/PDB/Raw/EnumTables.cpp:32-34
@@ +31,5 @@
+
+namespace llvm {
+namespace pdb {
+ArrayRef<EnumEntry<uint16_t>> getOMFSegMapDescFlagNames() {
+  return makeArrayRef(OMFSegMapDescFlagNames);
----------------
A less fragile way to do this is to declare it like:
  ArrayRef<EnumEntry<uint16_t>> llvm::pdb::getOMFSegMapDescFlagNames() { ...


http://reviews.llvm.org/D20876