[PATCH] D20717: pdbdump: print out COFF section headers.

[Zachary Turner via llvm-commits]

zturner added inline comments.

================
Comment at: include/llvm/DebugInfo/PDB/Raw/PDBFile.h:79-80
@@ -69,2 +78,4 @@
   Expected<SymbolStream &> getPDBSymbolStream();
+  Expected<codeview::FixedStreamArray<object::coff_section>>
+      getPDBSectionHeaders();
 
----------------
ruiu wrote:
> zturner wrote:
> > I don't think this should go in `PDBFile`.  Seems to me like it should be accessible from `DBIStream`.
> So is publics stream?
I think publics stream is fine at the top level.  After all, it is a top-level stream, you just have to look in the DBI stream to figure out its index.  The coff section headers though is just an array that is embedded entirely inside the DBI Stream.

It's kind of a judgement call though, I wouldn't object to publics stream being accessible from DBI stream, but I think "streams" are the only thing that should be accessible from the file.


http://reviews.llvm.org/D20717