[PATCH] D20854: [test-suite] Use shellcommand.wrap() when adding the run_under command
Matthias Braun via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 1 10:56:56 PDT 2016
MatzeB accepted this revision.
MatzeB added a comment.
This revision is now accepted and ready to land.
LGTM. Though I would recommend adding some checks:
================
Comment at: litsupport/run_under.py:9-10
@@ +8,4 @@
+
+ cmd.wrap(run_under_cmd.executable,
+ run_under_cmd.arguments)
+
----------------
This looks like it can fit into a single line.
You should play it safe and abort if run_under_cmd has any of the `stdin, stdout, stderr, workdir, envvars` properties set because they will get lost here.
http://reviews.llvm.org/D20854
More information about the llvm-commits
mailing list