[PATCH] D20262: [DSE]Split memset when the memset is small enough to be lowered to stores

[Jun Bum Lim via llvm-commits]

junbuml added a comment.

> +Mehdi, who set the mandatory data layout.


Can you please clarify about the mandatory? The reason I'm asking is because I can still see many test cases without datalayout.

> Having  DL.getLargestLegalIntTypeSizeInBits() returning 0 would mean that someone specifically asked for not having int types supported at all. Handling this case means that LLVM acknowledges that it aims at supporting this case. Is it possible/desirable to support this? Otherwise an assertion would be more appropriate IMO.


If having  DL.getLargestLegalIntTypeSizeInBits() returning 0 is undesirable, I think we should assert in getLargestLegalIntTypeSizeInBits().


http://reviews.llvm.org/D20262