[PATCH] D20741: [LibFuzzer] Reimplement how the optional user functions are called.

[Kostya Serebryany via llvm-commits]

kcc added inline comments.

================
Comment at: lib/Fuzzer/FuzzerDriver.cpp:422
@@ +421,3 @@
+  assert(argc && argv && "Argument pointers cannot be nullptr");
+  fuzzer::ExternalFunctions EF;
+  EF.Init();
----------------
move all of this into the other FuzzerDriver. 
This one is an atavism of my poor design choice in the past, let's not resurrect it. 

================
Comment at: lib/Fuzzer/FuzzerInternal.h:475
@@ -471,1 +474,3 @@
+  // Interface to functions that may or may not be available.
+  ExternalFunctions EF;
 };
----------------
I did not suggest to pass it by value. 
Can't it be created inside Fuzzer::Fuzzer with a default CTOR? 



http://reviews.llvm.org/D20741