[PATCH] D20840: [codeview] Translate basic DITypes to CV type records

[David Majnemer via llvm-commits]

majnemer accepted this revision.
majnemer added a reviewer: majnemer.
majnemer added a comment.
This revision is now accepted and ready to land.

LGTM!

We should have a todo for:

  using HRESULT = long;
  HRESULT an_hresult;

MSVC emits:

> (000070) S_GDATA32: [0000:00000000], Type:    T_HRESULT(0008), an_hresult



================
Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:757
@@ +756,3 @@
+  Kind = static_cast<dwarf::TypeKind>(Ty->getEncoding());
+  ByteSize = Ty->getSizeInBits() >> 3;
+
----------------
Divide by eight for consistency?


http://reviews.llvm.org/D20840