[PATCH] D20741: [LibFuzzer] Fix weak linking issues building tests under OSX.

Dan Liew via llvm-commits llvm-commits at lists.llvm.org
Tue May 31 18:13:34 PDT 2016


delcypher added a comment.

In http://reviews.llvm.org/D20741#445216, @kcc wrote:

> > I think it's probably fine for now but I don't think the goal of having a really simple compilation command line for LibFuzzer is sustainable long term
>
>
> I am not convinced. Worked well so far. We have a very similar code structure for the sanitizers, btw, 
>  and they, at least asan, are ported to more platforms than the rest of LLVM is.


But aren't the sanitizers a little different? They are part of compiler-rt which AFAIK is always built using clang (or maybe gcc?). LibFuzzer however could conceivably be built with MSVC (which is a very different beast) one day. Of course the code that needs to be instrumented has to be built with clang so my argument here is a little weak.


http://reviews.llvm.org/D20741





More information about the llvm-commits mailing list