[PATCH] D20579: [esan] Add circular buffer data structure

Derek Bruening via llvm-commits llvm-commits at lists.llvm.org
Tue May 31 17:55:36 PDT 2016


bruening added inline comments.

================
Comment at: compiler-rt/trunk/lib/esan/esan_circular_buffer.h:43
@@ +42,3 @@
+  void free() {
+    UnmapOrDie(Data, Capacity * sizeof(T));
+  }
----------------
vitalybuka wrote:
> private: free() ?
> 
See the comment at lines 19-22: one usage pattern is to explicitly call free so it needs to be public.


Repository:
  rL LLVM

http://reviews.llvm.org/D20579





More information about the llvm-commits mailing list