[PATCH] D20703: [SCEV] Keep SCEVExpander insert points consistent.
Sanjoy Das via llvm-commits
llvm-commits at lists.llvm.org
Tue May 31 16:38:55 PDT 2016
sanjoy accepted this revision.
sanjoy added a comment.
This revision is now accepted and ready to land.
lgtm with nits, thanks!
> I'm not entirely pleased with the duplicating of InsertPointGuard, though I also wasn't pleased with changing the InsertPointGuard interface.
Yes, but it seems to be the lesser of two evils. :)
================
Comment at: include/llvm/Analysis/ScalarEvolutionExpander.h:121
@@ +120,3 @@
+ };
+ /// Stack of pointers to saved insert points, used to keep insert points
+ /// consistent when instructions are moved.
----------------
Minor: add newline between declarations.
================
Comment at: include/llvm/Analysis/ScalarEvolutionExpander.h:123
@@ +122,3 @@
+ /// consistent when instructions are moved.
+ SmallVector<SCEVInsertPointGuard *, 8> InsertPointGuards;
+
----------------
Assert that this is empty when destroying a SCEVExpander.
================
Comment at: include/llvm/Analysis/ScalarEvolutionExpander.h:188
@@ -148,1 +187,3 @@
+ void fixupInsertPoints(Instruction *I);
+
----------------
This should be a private function.
http://reviews.llvm.org/D20703
More information about the llvm-commits
mailing list