[PATCH] D20741: [LibFuzzer] Fix weak linking issues building tests under OSX.

[Kostya Serebryany via llvm-commits]

kcc added a comment.

LG overall, add comments. 
For simpler review, I;d actually say that you better finish this one w/o adding __sanitizer_* functions and commit. 
Then make another change for __sanitizer*


================
Comment at: lib/Fuzzer/FuzzerInternal.h:473
@@ +472,3 @@
+
+  // Interface to functions that might be available.
+  ExternalFunctions EF;
----------------
s/might/may or may not/

================
Comment at: lib/Fuzzer/FuzzerMain.cpp:25
@@ +24,3 @@
+  EF.Init();
+  if (EF.LLVMFuzzerInitialize)
+    EF.LLVMFuzzerInitialize(&argc, &argv);
----------------
Instead of creating two EF instances it's probably reasonable to move this code inside FuzzerDriver. Please do so.


http://reviews.llvm.org/D20741