[PATCH] D20822: [CMake] Update to retiring CMake 3.4.3

[Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL271325: [CMake] Update to requiring CMake 3.4.3 (authored by cbieneman).

Changed prior to commit:
  http://reviews.llvm.org/D20822?vs=59093&id=59121#toc

Repository:
  rL LLVM

http://reviews.llvm.org/D20822

Files:
  llvm/trunk/CMakeLists.txt
  llvm/trunk/docs/CMake.rst
  llvm/trunk/docs/GettingStarted.rst

Index: llvm/trunk/docs/CMake.rst
===================================================================
--- llvm/trunk/docs/CMake.rst
+++ llvm/trunk/docs/CMake.rst
@@ -561,7 +561,7 @@
 
 .. code-block:: cmake
 
-  cmake_minimum_required(VERSION 2.8.8)
+  cmake_minimum_required(VERSION 3.4.3)
   project(SimpleProject)
 
   find_package(LLVM REQUIRED CONFIG)
Index: llvm/trunk/docs/GettingStarted.rst
===================================================================
--- llvm/trunk/docs/GettingStarted.rst
+++ llvm/trunk/docs/GettingStarted.rst
@@ -83,9 +83,11 @@
    before trying to configure with cmake.  cmake does not pickup newly
    added source directories in incremental builds. 
 
-   The build uses `CMake <CMake.html>`_.
-   Although the build is known to work with CMake >= 2.8.8, we recommend CMake
-   >= v3.2, especially if you're generating Ninja build files.
+   The build uses `CMake <CMake.html>`_. LLVM requires CMake 3.4.3 to build. It
+   is generally recommended to use a recent CMake, especially if you're
+   generating Ninja build files. This is because the CMake project is constantly
+   improving the quality of the generators, and the Ninja generator gets a lot
+   of attention.
 
    * ``cd where you want to build llvm``
    * ``mkdir build``
Index: llvm/trunk/CMakeLists.txt
===================================================================
--- llvm/trunk/CMakeLists.txt
+++ llvm/trunk/CMakeLists.txt
@@ -1,6 +1,6 @@
 # See docs/CMake.html for instructions about how to build LLVM with CMake.
 
-cmake_minimum_required(VERSION 2.8.12.2)
+cmake_minimum_required(VERSION 3.4.3)
 
 if (NOT CMAKE_BUILD_TYPE AND NOT CMAKE_CONFIGURATION_TYPES)
   message(STATUS "No build type selected, default to Debug")


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D20822.59121.patch
Type: text/x-patch
Size: 1737 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160531/b1942408/attachment.bin>