[PATCH] D20762: AArch64: Do not test for CPUs, use SubtargetFeatures

Matthias Braun via llvm-commits llvm-commits at lists.llvm.org
Tue May 31 13:24:30 PDT 2016


MatzeB updated this revision to Diff 59118.
MatzeB marked 3 inline comments as done.
MatzeB added a comment.

Thanks for the reviews and irc discussions!
Some of the subtarget features I felt indeed strange because they were adjusting some cost settings rather than just enabling/disabling a tweak. We lack a good mechanism to specify those in tablegen today so instead I opted to move all of those into a newly introduced initializeProperties() function.

We should support setting non-boolean properties based on the CPU with a tablegen feature. However that is material for a future patch.


Repository:
  rL LLVM

http://reviews.llvm.org/D20762

Files:
  lib/Target/AArch64/AArch64.td
  lib/Target/AArch64/AArch64A57FPLoadBalancing.cpp
  lib/Target/AArch64/AArch64ISelLowering.cpp
  lib/Target/AArch64/AArch64InstrInfo.cpp
  lib/Target/AArch64/AArch64InstrInfo.td
  lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp
  lib/Target/AArch64/AArch64Subtarget.cpp
  lib/Target/AArch64/AArch64Subtarget.h
  lib/Target/AArch64/AArch64TargetMachine.cpp
  lib/Target/AArch64/AArch64TargetTransformInfo.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D20762.59118.patch
Type: text/x-patch
Size: 25945 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160531/98fc5cfd/attachment-0001.bin>


More information about the llvm-commits mailing list