[PATCH] D20825: Don't force Python2.7

Luke Drummond via llvm-commits llvm-commits at lists.llvm.org
Tue May 31 11:14:51 PDT 2016


ldrumm created this revision.
ldrumm added subscribers: llvm-commits, zturner.
ldrumm set the repository for this revision to rL LLVM.

llvm's CMakeLists has a Special case to reject python versions != 2.7 due to a dependency on that version by `lldb` that is no longer required.

[224948](http://reviews.llvm.org/rL224948) was introduced to workaround this limitation in lldb. However it appears this is no needed, as lldb builds with python >= 2.7 since @zturner [made improvements to the lldb's cmake in 249466](http://reviews.llvm.org/rL249466), supporting python3 in lldb. Additionally, python 3.5 is required for Visual Studio 2015 debug builds with python bindings, so the reasons for this limitation seem obsolete.

I'm not sure whether there are other repercussions from disabling this check, so I'd appreciate comments with those more familiar with build system

Repository:
  rL LLVM

http://reviews.llvm.org/D20825

Files:
  CMakeLists.txt

Index: CMakeLists.txt
===================================================================
--- CMakeLists.txt
+++ CMakeLists.txt
@@ -450,10 +450,7 @@
 
 include(HandleLLVMOptions)
 
-# Verify that we can find a Python 2 interpreter.  Python 3 is unsupported.
-# FIXME: We should support systems with only Python 3, but that requires work
-# on LLDB.
-set(Python_ADDITIONAL_VERSIONS 2.7)
+# Verify that we can find a Python interpreter.
 include(FindPythonInterp)
 if( NOT PYTHONINTERP_FOUND )
   message(FATAL_ERROR


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D20825.59092.patch
Type: text/x-patch
Size: 515 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160531/63dbe353/attachment.bin>


More information about the llvm-commits mailing list