[PATCH] D20793: [ELF] - Implemented support for test/binop relaxations from latest ABI.

[Rafael Espíndola via llvm-commits]

On 31 May 2016 at 10:20, Rafael Ávila de Espíndola
<llvm-commits at lists.llvm.org> wrote:
> rafael added inline comments.
>
> ================
> Comment at: ELF/InputSection.cpp:260
> @@ -259,1 +259,3 @@
>      return Body.getVA<ELFT>(A) - P;
> +  case R_RELAX_GOT_PC_NOPIC:
> +    return Body.getVA<ELFT>();
> ----------------
> This is the same value as R_ABS, move it there.
>
> ================
> Comment at: ELF/Relocations.cpp:247
> @@ -246,3 +246,3 @@
>    return Expr == R_PC || Expr == R_GOTREL || Expr == R_PAGE_PC ||
> -         Expr == R_RELAX_GOT_PC;
> +         Expr == R_RELAX_GOT_PC || Expr == R_RELAX_GOT_PC_NOPIC;
>  }
> ----------------
> This one is not RelExpr if it has the same value as R_ABS.
>
> ================
> Comment at: ELF/Relocations.h:42
> @@ -41,2 +41,3 @@
>    R_RELAX_GOT_PC,
> +  R_RELAX_GOT_PC_NOPIC,
>    R_RELAX_TLS_GD_TO_IE,
> ----------------
> Maybe just name this R_RELAX_GOT.

Never mind this bit. Thinking a bit more I realized
R_RELAX_GOT_PC_NOPIC is a better name.

Cheers,
Rafael