[PATCH] D20346: [stack-protection] Add support for MSVC buffer security check

[Etienne Bergeron via llvm-commits]

etienneb added a comment.

In http://reviews.llvm.org/D20346#439984, @majnemer wrote:

> Should those be updated later?


Yes.

I had few examples where the choice of 'personality' is changed from version 3 to version 4 when /GS is on.
Also, the stack/EH security cookies must be added to the structure when using version 3.

> Should we not enable /GS by default until they are implemented?


This should/could be kept off until other pieces are in place.


http://reviews.llvm.org/D20346