[PATCH] D20624: [mips] bnec/beqc register constraint fix

Daniel Sanders via llvm-commits llvm-commits at lists.llvm.org
Tue May 31 02:10:02 PDT 2016


dsanders accepted this revision.
dsanders added a comment.
This revision is now accepted and ready to land.

LGTM with the missing `[[` and `]]` added.


================
Comment at: test/CodeGen/Mips/compactbranches/beqc-bnec-register-constraint.ll:35-36
@@ +34,4 @@
+  %a11 = load i32, i32* %alsr.iv339, align 4, !tbaa !5
+; CHECK-NOT: bnec $[[R0:[0-9]+]], R0
+; CHECK-NOT: beqc $[[R1:[0-9]+]], R1
+  %alnot137 = icmp eq i32 %a9, %a11
----------------
dsanders wrote:
>   ; CHECK-NOT: bnec $[[R0:[0-9]+]], R0
> 
> The `R0` and `R1` should be `[[R0]]` and `[[R1]]`
> 
> Also, I'm not sure variables can be used in the same directive that defines them. I'll double check that.
> Also, I'm not sure variables can be used in the same directive that defines them. I'll double check that.

This works.


http://reviews.llvm.org/D20624





More information about the llvm-commits mailing list