[PATCH] D20776: [CFLAA] Teach cfl-aa to understand heap memory allocation

Jia Chen via llvm-commits llvm-commits at lists.llvm.org
Mon May 30 12:32:49 PDT 2016


grievejia added a comment.

In http://reviews.llvm.org/D20776#443765, @george.burgess.iv wrote:

> We need to do this because, if the result of the malloc is otherwise unused, we'll not see it in the stratified sets. If something's not in the stratified sets, we'll assume it was added after we ran on the function, so we're conservative and always just say MayAlias. If we're not doing the same thing with otherwise-unused allocas, we probably should be.


You are right. I think we are doing this for unused allocas, outside GetEdgeVisitor.

Any reason for (1) not adding unused value to StratifiedSets, and (2) treating values not in StratifiedSets conservatively?


http://reviews.llvm.org/D20776





More information about the llvm-commits mailing list