[PATCH] D20762: AArch64: Do not test for CPUs, use SubtargetFeatures

[Diana Picus via llvm-commits]

rovka added a subscriber: rovka.
rovka added a comment.

LGTM, but you should wait for someone more versed to approve.


================
Comment at: lib/Target/AArch64/AArch64.td:72
@@ +71,3 @@
+
+def FeaturePredicatbleSelectIsExpensive : SubtargetFeature<
+    "predictable-select-expensive", "PredictableSelectIsExpensive", "true",
----------------
typo: Predictable

================
Comment at: lib/Target/AArch64/AArch64ISelLowering.cpp:8813
@@ -8814,3 +8812,3 @@
 
   // Cyclone has bad performance on unaligned 16B stores when crossing line and
   // page boundaries. We want to split such stores.
----------------
You could make this comment sound more generic (e.g. use "Some subtargets" instead of "Cyclone").

================
Comment at: lib/Target/AArch64/AArch64InstrInfo.cpp:1524
@@ -1524,2 +1523,3 @@
 
   // Do not pair quad ld/st for Exynos.
+  if (Subtarget.avoidQuadLdStPairs()) {
----------------
I think you can remove or rephrase this comment.

================
Comment at: lib/Target/AArch64/AArch64InstrInfo.cpp:1804
@@ -1805,2 +1803,3 @@
+  if (Subtarget.hasMacroOpFusion()) {
     // Cyclone can fuse CMN, CMP, TST followed by Bcc.
     unsigned SecondOpcode = Second->getOpcode();
----------------
I think you can remove/rephrase this comment as well.


Repository:
  rL LLVM

http://reviews.llvm.org/D20762